Closed
Bug 1736438
Opened 4 years ago
Closed 4 years ago
PingCentre import of sendStandalonePing is incorrect
Categories
(Toolkit :: Telemetry, defect)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
95 Branch
| Tracking | Status | |
|---|---|---|
| firefox95 | --- | fixed |
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
|
Assignee | |
Comment 1•4 years ago
|
||
I'm not actually sure how to test this, given that it passed on CI. But
the fix seems simple enough.
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/09c04cc996ae
Fix import for sendStandalonePing. r=nanj
|
||
Comment 3•4 years ago
•
|
||
FWIW, I see this in my ctrl+shift+J Browser Console whenever I try to save an article to Pocket (with the toolbar Pocket icon) in today's Nightly:
TypeError: TelemetrySend.sendStandalonePing is not a function
...and then the Save-To-Pocket operation never seems to complete (the throbber keeps spinning and https://getpocket.com/my-list never changes). I suspect this failure is possibly due to that TypeError (e.g. perhaps it's uncaught and makes the Pocket operation bail out?) but I'm not sure.
Anyway: I suspect this bug's patch will address the above logging, and possibly the failing Save-to-Pocket operation as well.
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox95:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•